On Tue, 4 Feb 2025 15:06:19 -0700 Ahmed Zaki wrote:
> + * @irq_affinity_auto: driver wants the core to manage the IRQ affinity.
"manage" is probably too strong? "store" or "remember" ?
Your commit message explains it quite nicely.
> + * Set by netif_enable_irq_affinity(), then driver must
> + * create persistent napi by netif_napi_add_config()
> + * and finally bind napi to IRQ (netif_napi_set_irq).
> + *
> * @rx_cpu_rmap_auto: driver wants the core to manage the ARFS rmap.
> * Set by calling netif_enable_cpu_rmap().
> *
> @@ -2402,6 +2406,7 @@ struct net_device {
> struct lock_class_key *qdisc_tx_busylock;
> bool proto_down;
> bool threaded;
> + bool irq_affinity_auto;
> bool rx_cpu_rmap_auto;
>
> /* priv_flags_slow, ungrouped to save space */
> @@ -2662,6 +2667,11 @@ static inline void netdev_set_ml_priv(struct
> net_device *dev,
> dev->ml_priv_type = type;
> }
>
> +static inline void netif_enable_irq_affinity(struct net_device *dev)
Similar here, "enable affinity" is a bit strong.
netif_remember_irq_affinity() would be more accurate IMHO
> +{
> + dev->irq_affinity_auto = true;
> +}
