> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Kwapulinski, Piotr > Sent: 31 January 2025 17:45 > To: [email protected] > Cc: [email protected]; [email protected]; > [email protected]; Fijalkowski, Maciej <[email protected]>; > Kitszel, Przemyslaw <[email protected]>; Kwapulinski, Piotr > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next v4] ixgbe: Fix possible skb NULL > pointer dereference > > The commit c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in > ixgbe_run_xdp()") stopped utilizing the ERR-like macros for xdp status > encoding. Propagate this logic to the ixgbe_put_rx_buffer(). > > The commit also relaxed the skb NULL pointer check - caught by Smatch. > Restore this check. > > Fixes: c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()") > Reported-by: Dan Carpenter <[email protected]> > Acked-by: Maciej Fijalkowski <[email protected]> > Signed-off-by: Piotr Kwapulinski <[email protected]> > --- > v1 -> v2 > Provide extra details in commit message for motivation of this patch > v2 -> v3 > Simplify the check condition > v3 -> v4 > Rebase to net-queue > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Tested-by: Saritha Sanigani <[email protected]> (A Contingent Worker at Intel)
