> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Vladimir Oltean
> Sent: Wednesday, February 12, 2025 11:01 PM
> To: Faizal Rahim <[email protected]>
> Cc: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw
> <[email protected]>; Andrew Lunn <[email protected]>;
> David S . Miller <[email protected]>; Eric Dumazet
> <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni
> <[email protected]>; Maxime Coquelin <[email protected]>;
> Alexandre Torgue <[email protected]>; Simon Horman
> <[email protected]>; Russell King <[email protected]>; Alexei
> Starovoitov <[email protected]>; Daniel Borkmann <[email protected]>;
> Jesper Dangaard Brouer <[email protected]>; John Fastabend
> <[email protected]>; Furong Xu <[email protected]>; Russell King
> <[email protected]>; Serge Semin <[email protected]>;
> Xiaolei Wang <[email protected]>; Suraj Jaiswal
> <[email protected]>; Kory Maincent <[email protected]>;
> Gal Pressman <[email protected]>; Jesper Nilsson <[email protected]>;
> Andrew Halaney <[email protected]>; Choong Yong Liang
> <[email protected]>; Kunihiko Hayashi
> <[email protected]>; Gomes, Vinicius
> <[email protected]>; [email protected];
> [email protected]; [email protected]; linux-stm32@st-md-
> mailman.stormreply.com; [email protected];
> [email protected]
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 0/9] igc: Add support for
> Frame Preemption feature in IGC
Please start commit title from slam letters:
Igc: add ...
> On Mon, Feb 10, 2025 at 02:01:58AM -0500, Faizal Rahim wrote:
> > Introduces support for the FPE feature in the IGC driver.
> >
> > The patches aligns with the upstream FPE API:
> >
> https://patchwork.kernel.org/project/netdevbpf/cover/20230220122343.1
> 1
> > [email protected]/
> >
> https://patchwork.kernel.org/project/netdevbpf/cover/20230119122705.7
> 3
> > [email protected]/
> >
> > It builds upon earlier work:
> >
> https://patchwork.kernel.org/project/netdevbpf/cover/20220520011538.1
> 0
> > [email protected]/
> >
> > The patch series adds the following functionalities to the IGC driver:
> > a) Configure FPE using `ethtool --set-mm`.
> > b) Display FPE settings via `ethtool --show-mm`.
> > c) View FPE statistics using `ethtool --include-statistics --show-mm'.
> > e) Enable preemptible/express queue with `fp`:
> > tc qdisc add ... root taprio \
> > fp E E P P
>
> Any reason why you are only enabling the preemptible traffic classes with
> taprio, and not with mqprio as well? I see there will have to be some work
> harmonizing igc's existing understanding of ring priorities with what Kurt
> did in
> 9f3297511dae ("igc: Add MQPRIO offload support"), and I was kind of
> expecting to see a proposal for that as part of this.
