Re: [Intel-wired-lan] [PATCH iwl-next] igc: Change Tx mode for MQPRIO offloading

[Abdul Rahim, Faizal]

On 17/2/2025 7:45 pm, Kurt Kanzenbach wrote:

The current MQPRIO offload implementation uses the legacy TSN Tx mode. In
this mode the hardware uses four packet buffers and considers queue
priorities.

In order to harmonize the TAPRIO implementation with MQPRIO switch to the

Missed "," ?
In order to harmonize the TAPRIO implementation with MQPRIO, switch to the

diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c 
b/drivers/net/ethernet/intel/igc/igc_tsn.c
index 
1e44374ca1ffbb86e9893266c590f318984ef574..6e4582de9602db2c6667f1736cc2acaa4d4b5201
 100644
--- a/drivers/net/ethernet/intel/igc/igc_tsn.c
+++ b/drivers/net/ethernet/intel/igc/igc_tsn.c
@@ -47,7 +47,7 @@ static unsigned int igc_tsn_new_flags(struct igc_adapter 
*adapter)
                new_flags |= IGC_FLAG_TSN_QAV_ENABLED;

if (adapter->strict_priority_enable)

-               new_flags |= IGC_FLAG_TSN_LEGACY_ENABLED;
+               new_flags |= IGC_FLAG_TSN_QBV_ENABLED;

return new_flags;

  }

IGC_FLAG_TSN_QBV_ENABLED is set multiple times in different lines:

        if (adapter->taprio_offload_enable)
                new_flags |= IGC_FLAG_TSN_QBV_ENABLED;

        if (is_any_launchtime(adapter))
                new_flags |= IGC_FLAG_TSN_QBV_ENABLED;

        if (is_cbs_enabled(adapter))
                new_flags |= IGC_FLAG_TSN_QAV_ENABLED;

        if (adapter->strict_priority_enable)
                new_flags |= IGC_FLAG_TSN_QBV_ENABLED;

        return new_flags;
}

We can combine the conditions to simplify:
        if (adapter->taprio_offload_enable ||
            is_any_launchtime(adapter) ||
            adapter->strict_priority_enable)
                new_flags |= IGC_FLAG_TSN_QBV_ENABLED;