> -----Original Message-----
> From: Marcin Szycik <[email protected]>
> Sent: Tuesday, February 11, 2025 11:13 PM
> To: [email protected]
> Cc: [email protected]; [email protected]; Marcin
> Szycik <[email protected]>; Buvaneswaran, Sujai
> <[email protected]>; Martyna Szapar-Mudlaw
> <[email protected]>
> Subject: [PATCH iwl-net 2/2] ice: Avoid setting default Rx VSI twice in
> switchdev setup
>
> As part of switchdev environment setup, uplink VSI is configured as default
> for both Tx and Rx. Default Rx VSI is also used by promiscuous mode. If
> promisc mode is enabled and an attempt to enter switchdev mode is made,
> the setup will fail because Rx VSI is already configured as default (rule
> exists).
>
> Reproducer:
> devlink dev eswitch set $PF1_PCI mode switchdev
> ip l s $PF1 up
> ip l s $PF1 promisc on
> echo 1 > /sys/class/net/$PF1/device/sriov_numvfs
>
> In switchdev setup, use ice_set_dflt_vsi() instead of plain
> ice_cfg_dflt_vsi(),
> which avoids repeating setting default VSI for Rx if it's already configured.
>
> Fixes: 50d62022f455 ("ice: default Tx rule instead of to queue")
> Reported-by: Sujai Buvaneswaran <[email protected]>
> Closes: https://lore.kernel.org/intel-wired-
> lan/[email protected]
> prd11.prod.outlook.com
> Reviewed-by: Martyna Szapar-Mudlaw <martyna.szapar-
> [email protected]>
> Signed-off-by: Marcin Szycik <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_eswitch.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Tested-by: Sujai Buvaneswaran <[email protected]>
