> -----Original Message-----
> From: Paul Menzel <[email protected]>
> Sent: Friday, February 21, 2025 3:34 PM
> To: Nitka, Grzegorz <[email protected]>; intel-wired-
> [email protected]
> Cc: Loktionov, Aleksandr <[email protected]>;
> [email protected]
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: Allow 100M speed for
> E825C SGMII device
>
> Dear Grzegorz,
>
>
> Thank you for the patch.
>
> Am 21.02.25 um 11:16 schrieb Grzegorz Nitka:
> > Add E825C 10GbE SGMII device to the list of devices supporting 100Mbit
> > link mode. Without that change, 100Mbit link mode is ignored in ethtool
> > interface. This change was missed while adding the support for E825C
> > devices family.
>
> I always like to have the commands and output for reproducing the issue
> in the commit message. That way, people hitting the error, have a chance
> of finding the commit, for example, with search engines.
>
Dear Paul,
Thank you for reviewing this.
I've just submitted v2 with improved commit message (testing hint added)
Regards
Grzegorz
> > Fixes: f64e189442332 ("ice: introduce new E825C devices family")
> > Signed-off-by: Grzegorz Nitka <[email protected]>
> > Reviewed-by: Aleksandr Loktionov <[email protected]>
> > ---
> > drivers/net/ethernet/intel/ice/ice_common.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_common.c
> b/drivers/net/ethernet/intel/ice/ice_common.c
> > index 7a2a2e8da8fa..caf3af2a32c3 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_common.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> > @@ -3180,6 +3180,7 @@ bool ice_is_100m_speed_supported(struct
> ice_hw *hw)
> > case ICE_DEV_ID_E822L_SGMII:
> > case ICE_DEV_ID_E823L_1GBE:
> > case ICE_DEV_ID_E823C_SGMII:
> > + case ICE_DEV_ID_E825C_SGMII:
> > return true;
> > default:
> > return false;
> Reviewed-by: Paul Menzel <[email protected]>
>
>
> Kind regards,
>
> Paul
