Dear Kurt,
Thank you for the patch. Am 24.02.25 um 11:05 schrieb Kurt Kanzenbach:
The current MQPRIO offload implementation uses the legacy TSN Tx mode. In this mode the hardware uses four packet buffers and considers queue priorities.
If I didn’t miss anything, later on you do not specify how many buffers are used after changing the Tx mode.
In order to harmonize the TAPRIO implementation with MQPRIO, switch to the regular TSN Tx mode. In addition to the legacy mode, transmission is always coupled to Qbv. The driver already has mechanisms to use a dummy schedule of 1 second with all gates open for ETF. Simply use this for MQPRIO too. This reduces code and makes it easier to add support for frame preemption later. While at it limit the netdev_tc calls to MQPRIO only. Tested on i225 with real time application using high priority queue, iperf3 using low priority queue and network TAP device. Signed-off-by: Kurt Kanzenbach <[email protected]> --- Changes in v2: - Add comma to commit message (Faizal) - Simplify if condition (Faizal) - Link to v1: https://lore.kernel.org/r/[email protected] --- drivers/net/ethernet/intel/igc/igc.h | 4 +--- drivers/net/ethernet/intel/igc/igc_main.c | 18 +++++++++++++- drivers/net/ethernet/intel/igc/igc_tsn.c | 40 ++----------------------------- 3 files changed, 20 insertions(+), 42 deletions(-)
[…] Kind regards, Paul
