> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Przemek Kitszel > Sent: Wednesday, February 19, 2025 5:31 AM > To: [email protected]; Nguyen, Anthony L > <[email protected]>; Jiri Pirko <[email protected]>; Jakub Kicinski > <[email protected]> > Cc: [email protected]; Kitszel, Przemyslaw > <[email protected]>; Loktionov, Aleksandr > <[email protected]>; Michal Swiatkowski > <[email protected]>; Knitter, Konrad > <[email protected]>; Polchlopek, Mateusz > <[email protected]>; Simon Horman <[email protected]> Subject: [Intel-wired-lan] [PATCH iwl-net v1] ice: register devlink prior to creating health reporters > > ice_health_init() was introduced in the commit 2a82874a3b7b ("ice: add > Tx hang devlink health reporter"). The call to it should have been put > after ice_devlink_register(). It went unnoticed until next reporter by > Konrad, which recieves events from FW. FW is reporting all events, also > from prior driver load, and thus it is not unlikely to have something > at the very begining. And that results in a splat: > [ 24.455950] ? devlink_recover_notify.constprop.0+0x198/0x1b0 > [ 24.455973] devlink_health_report+0x5d/0x2a0 > [ 24.455976] ? __pfx_ice_health_status_lookup_compare+0x10/0x10 [ice] > [ 24.456044] ice_process_health_status_event+0x1b7/0x200 [ice] > >Do the analogous thing for deinit patch. > > Fixes: 85d6164ec56d ("ice: add fw and port health reporters") > Reviewed-by: Aleksandr Loktionov <[email protected]> > Reviewed-by: Michal Swiatkowski <[email protected]> > Reviewed-by: Konrad Knitter <[email protected]> > Signed-off-by: Przemek Kitszel <[email protected]> > --- > Konrad wonders if regions registration should too be moved prior > to devlink_register(). From net/devlink code it looks safe both ways, > and there is no documentation on what should be the registration order. > (But in the past some things were necessary to be prior to register). > > CC: Mateusz Polchlopek <[email protected]> > CC: Simon Horman <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Tested-by: Sunitha Mekala <[email protected]> (A Contingent worker at Intel)
