On Wed, Feb 26, 2025 at 12:33:56PM +0100, Mateusz Polchlopek wrote: > Embed ice_get_tx_topo_user_sel() inside the only caller: > ice_devlink_tx_sched_layers_get(). > Instead of jump from the wrapper to the function that does "get" operation > it does "get" itself. > > Remove unnecessary comment and make usage of str_enabled_disabled() > in ice_init_tx_topology().
Hi Mateusz, These changes seem reasonable to me. But I wonder if they could be motivated in the commit message. What I mean is, the commit message explains what has been done. But I think it should explain why it has been done. > Suggested-by: Marcin Szycik <[email protected]> > Reviewed-by: Michal Swiatkowski <[email protected]> > Reviewed-by: Jedrzej Jagielski <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > Reviewed-by: Aleksandr Loktionov <[email protected]> > Signed-off-by: Mateusz Polchlopek <[email protected]> ...
