> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Przemek Kitszel > Sent: Tuesday, March 4, 2025 9:28 AM > To: joaomboni <[email protected]> > Cc: Nguyen, Anthony L <[email protected]>; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected] > Subject: Re: [Intel-wired-lan] [PATCH v2] e1000: The 'const' qualifier has > been > added where applicable to enhance code safety and prevent unintended > modifications. > > On 3/3/25 21:47, joaomboni wrote: > > Signed-off-by: Joao Bonifacio <[email protected]> > > it will be good to use imperative mood in the Subject, and add one more > paragraph, like: > > Subject: e1000: mark global variables const where possible > I'd suggest 'fix' e1000: fix global variables const where possible But anyway the change is useful and so small and well-understandable.
> Next paragraph: > Mark global variables const, so unintended modification would not be > possible. > > > --- > > drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c > > b/drivers/net/ethernet/intel/e1000/e1000_main.c > > index 3f089c3d47b2..96bc85f09aaf 100644 > > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c > > +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c > > @@ -9,7 +9,7 @@ > > #include <linux/if_vlan.h> > > > > char e1000_driver_name[] = "e1000"; > > your commit message suggests that you add const "everywhere", but it seems > that there are other candidates, like the one above > > PS. You have to wait 24h before posting next revision. > > > -static char e1000_driver_string[] = "Intel(R) PRO/1000 Network > > Driver"; > > +static const char e1000_driver_string[] = "Intel(R) PRO/1000 Network > > +Driver"; > > static const char e1000_copyright[] = "Copyright (c) 1999-2006 Intel > > Corporation."; > > > > /* e1000_pci_tbl - PCI Device ID Table
