From: Simon Horman <[email protected]> 
Sent: Wednesday, March 12, 2025 3:56 PM

>On Wed, Mar 12, 2025 at 01:58:39PM +0100, Jedrzej Jagielski wrote:
>
>...
>
>> diff --git a/Documentation/networking/devlink/ixgbe.rst 
>> b/Documentation/networking/devlink/ixgbe.rst
>> index a41073a62776..41aedf4b8017 100644
>> --- a/Documentation/networking/devlink/ixgbe.rst
>> +++ b/Documentation/networking/devlink/ixgbe.rst
>> @@ -64,3 +64,27 @@ The ``ixgbe`` driver reports the following versions
>>        - running
>>        - 0xee16ced7
>>        - The first 4 bytes of the hash of the netlist module contents.
>> +
>> +Flash Update
>> +============
>> +The ``ixgbe`` driver implements support for flash update using the
>> +``devlink-flash`` interface. It supports updating the device flash using a
>> +combined flash image that contains the ``fw.mgmt``, ``fw.undi``, and
>> +``fw.netlist`` components.
>> +.. list-table:: List of supported overwrite modes
>> +   :widths: 5 95
>
>Hi Jedrzej,
>
>make htmldocs flags two warnings, which I believe can be resolved by
>adding a blank line here.
>
>  .../ixgbe.rst:75: ERROR: Unexpected indentation.
>  .../ixgbe.rst:76: WARNING: Field list ends without a blank line; unexpected 
> unindent.

Hello Simon

thanks for finding these.

I will fix it and resend it later today probably.

>
>> +   * - Bits
>> +     - Behavior
>> +   * - ``DEVLINK_FLASH_OVERWRITE_SETTINGS``
>> +     - Do not preserve settings stored in the flash components being
>> +       updated. This includes overwriting the port configuration that
>> +       determines the number of physical functions the device will
>> +       initialize with.
>> +   * - ``DEVLINK_FLASH_OVERWRITE_SETTINGS`` and 
>> ``DEVLINK_FLASH_OVERWRITE_IDENTIFIERS``
>> +     - Do not preserve either settings or identifiers. Overwrite everything
>> +       in the flash with the contents from the provided image, without
>> +       performing any preservation. This includes overwriting device
>> +       identifying fields such as the MAC address, Vital product Data (VPD) 
>> area,
>> +       and device serial number. It is expected that this combination be 
>> used with an
>> +       image customized for the specific device.
>> +
>
>...

Reply via email to