The lan743x_ptp_io_event_cap_en() function checks that the given request
sets only one of PTP_RISING_EDGE or PTP_FALLING_EDGE, but not both.

However, this driver does not check whether other flags (such as
PTP_EXT_OFF) are set, nor whether any future unrecognized flags are set.

Fix this by adding the appropriate check to the lan743x_ptp_io_extts()
function.

Fixes: 60942c397af6 ("net: lan743x: Add support for PTP-IO Event Input External 
Timestamp (extts)")
Signed-off-by: Jacob Keller <[email protected]>
---
 drivers/net/ethernet/microchip/lan743x_ptp.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c 
b/drivers/net/ethernet/microchip/lan743x_ptp.c
index 
4a777b449ecd03ac0d7576f8570f1a7794fb3d06..0be44dcb339387e9756f36f909f65c20870bc49b
 100644
--- a/drivers/net/ethernet/microchip/lan743x_ptp.c
+++ b/drivers/net/ethernet/microchip/lan743x_ptp.c
@@ -942,6 +942,12 @@ static int lan743x_ptp_io_extts(struct lan743x_adapter 
*adapter, int on,
 
        extts = &ptp->extts[index];
 
+       if (extts_request->flags & ~(PTP_ENABLE_FEATURE |
+                                    PTP_RISING_EDGE |
+                                    PTP_FALLING_EDGE |
+                                    PTP_STRICT_FLAGS))
+               return -EOPNOTSUPP;
+
        if (on) {
                extts_pin = ptp_find_pin(ptp->ptp_clock, PTP_PF_EXTTS, index);
                if (extts_pin < 0)

-- 
2.48.1.397.gec9d649cc640

Reply via email to