On Fri, Mar 07, 2025 at 02:25:56PM +0100, Martyna Szapar-Mudlaw wrote: > From: Mateusz Polchlopek <[email protected]> > > Simplify the code by eliminating an unnecessary wrapper function. > Previously, ice_devlink_tx_sched_layers_get() acted as a thin wrapper > around ice_get_tx_topo_user_sel(), adding no real value but increasing > code complexity. Since both functions were only used once, the wrapper > was redundant and contributed approximately 20 lines of unnecessary > code. Remove ice_get_tx_topo_user_sel() and moves its instructions > directly into ice_devlink_tx_sched_layers_get(), improving readability > and reducing function jumps, without altering functionality.
Thanks, this explanation looks good to me. > > Also remove unnecessary comment and make usage of str_enabled_disabled() in > ice_init_tx_topology(). Sorry for not noticing this in my review of v1, but I would lean towards these changes being separate patches. That not withstanding, this looks good to me. Reviewed-by: Simon Horman <[email protected]> > Suggested-by: Marcin Szycik <[email protected]> > Reviewed-by: Michal Swiatkowski <[email protected]> > Reviewed-by: Jedrzej Jagielski <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > Reviewed-by: Aleksandr Loktionov <[email protected]> > Signed-off-by: Mateusz Polchlopek <[email protected]> > Signed-off-by: Martyna Szapar-Mudlaw <[email protected]> ...
