> -----Original Message----- > From: Simon Horman <[email protected]> > Sent: Monday, March 17, 2025 5:36 PM > To: Nitka, Grzegorz <[email protected]> > Cc: [email protected]; [email protected]; Kolacinski, > Karol <[email protected]>; Michal Swiatkowski > <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Subject: Re: [PATCH iwl-next v2 1/3] ice: remove SW side band access > workaround for E825 > > On Mon, Mar 10, 2025 at 01:24:37PM +0100, Grzegorz Nitka wrote: > > From: Karol Kolacinski <[email protected]> > > > > Due to the bug in FW/NVM autoload mechanism (wrong default > > SB_REM_DEV_CTL register settings), the access to peer PHY and CGU > > clients was disabled by default. > > > > As the workaround solution, the register value was overwritten by the > > driver at the probe or reset handling. > > Remove workaround as it's not needed anymore. The fix in autoload > > procedure has been provided with NVM 3.80 version. > > Hi Grzegorz, > > As per my belated comment on v2 [*], I think it would be worth adding > a brief comment here regarding this not being expected to cause > a regression in HW+FW seen in the wild. > > [*] https://lore.kernel.org/netdev/[email protected]/ >
Thanks Simon for your feedback. Sure, I'll address it in next version. Kind Regards Grzegorz > > > > Reviewed-by: Michal Swiatkowski <[email protected]> > > Reviewed-by: Przemek Kitszel <[email protected]> > > Signed-off-by: Karol Kolacinski <[email protected]> > > Signed-off-by: Grzegorz Nitka <[email protected]> > > ...
