> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Rand > Deeb > Sent: 06 March 2025 15:42 > To: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Andrew Lunn <[email protected]>; David S. > Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub > Kicinski <[email protected]>; Paolo Abeni <[email protected]>; moderated > list:INTEL ETHERNET DRIVERS <[email protected]>; open > list:NETWORKING DRIVERS <[email protected]>; open list > <[email protected]> > Cc: [email protected]; [email protected]; > [email protected]; Rand Deeb <[email protected]> > Subject: [Intel-wired-lan] [PATCH] ixgbe: Fix unreachable retry logic in > combined and byte I2C write functions > > The current implementation of `ixgbe_write_i2c_combined_generic_int` and > `ixgbe_write_i2c_byte_generic_int` sets `max_retry` to `1`, which makes the > condition `retry < max_retry` always evaluate to `false`. This renders the > retry mechanism ineffective, as the debug message and retry logic are never > executed. > > This patch increases `max_retry` to `3` in both functions, aligning them with > the retry logic in `ixgbe_read_i2c_combined_generic_int`. This ensures that > the retry mechanism functions as intended, improving robustness in case of > I2C write failures. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Rand Deeb <[email protected]> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
