Hi Sujai,

I reverified the issue, and with the patch, I am now getting the correct error about insufficient space, when attempting to add to many rules. The error you’re encountering might be caused by a different issue.

Could you please test it again or send me offline the set of rules you are adding? It seems to be working fine on my side.

Regards,
Martyna

On 4/1/2025 11:49 AM, Buvaneswaran, Sujai wrote:
Hi,

I tried to add tc rules to the HW beyond the maximum limit and still noticing 
the below error message instead of error message mentioned in the patch.

[root@dell-cnv-sut ~]# tc filter add dev ens5f0np0 ingress protocol ip prio 0 
flower skip_sw dst_mac 00:f0:01:00:00:0E action mirred egress redirect dev 
ens5f0npf0vf0
Error: ice: Unable to add filter due to error.
We have an error talking to the kernel

[root@dell-cnv-sut ~]# tc filter show dev ens5f0np0 root | grep -c in_hw
16306

Please check it.

Thanks,
Sujai B

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of
Simon Horman
Sent: Wednesday, March 19, 2025 5:48 PM
To: Martyna Szapar-Mudlaw <[email protected]>
Cc: [email protected]; [email protected]; Michal
Swiatkowski <[email protected]>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: improve error message for
insufficient filter space

On Fri, Mar 14, 2025 at 09:11:11AM +0100, Martyna Szapar-Mudlaw wrote:
When adding a rule to switch through tc, if the operation fails due to
not enough free recipes (-ENOSPC), provide a clearer error message:
"Unable to add filter: insufficient space available."

This improves user feedback by distinguishing space limitations from
other generic failures.

Reviewed-by: Michal Swiatkowski <[email protected]>
Signed-off-by: Martyna Szapar-Mudlaw
<[email protected]>

Reviewed-by: Simon Horman <[email protected]>



Reply via email to