On Mon, Apr 07, 2025 at 11:43:50AM +0100, Simon Horman wrote:
> On Fri, Apr 04, 2025 at 12:54:21PM +0200, Michal Swiatkowski wrote:
> > In case of failing on rss_data->rss_key allocation the function is
> > freeing vport without freeing earlier allocated q_vector_idxs. Fix it.
> >
> > Move from freeing in error branch to goto scheme.
> >
> > Fixes: 95af467d9a4e ("idpf: configure resources for RX queues")
>
> Hi Michal,
>
> WRT leaking q_vector_indxs, that allocation is not present at
> the commit cited above, so I think the correct Fixes tag for
> that problem is the following, where that allocation was added:
>
> Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
Thanks for checking that. I agree, my fixes is wrong.
>
> I do note that adapter->vport_config[idx] may be allocated but
> not freed on error in idpf_vport_alloc(). But I assume that this
> is not a leak as it will eventually be cleaned up by idpf_remove().
Right, it will be better to free it directly for better readable.
Probably candidate for net-next changes.
>
> So the Fixes tag not withstanding this looks good to me.
>
> Reviewed-by: Simon Horman <[email protected]>
>
Thanks for review.
> > Reviewed-by: Pavan Kumar Linga <[email protected]>
> > Reviewed-by: Aleksandr Loktionov <[email protected]>
> > Suggested-by: Pavan Kumar Linga <[email protected]>
> > Signed-off-by: Michal Swiatkowski <[email protected]>
>
> ...
