> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Thomas Weißschuh
> Sent: Monday, April 14, 2025 10:26 AM
> To: Jeff Johnson <[email protected]>; Loic Poulain
> <[email protected]>; Brian Norris <[email protected]>;
> Francesco Dolcini <[email protected]>; Nguyen, Anthony L
> <[email protected]>; Kitszel, Przemyslaw
> <[email protected]>; Andrew Lunn <[email protected]>;
> David S. Miller <[email protected]>; Dumazet, Eric
> <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni
> <[email protected]>; Saeed Mahameed <[email protected]>; Leon
> Romanovsky <[email protected]>; Tariq Toukan <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; intel-wired-
> [email protected]; [email protected]; [email protected];
> Thomas Weißschuh <[email protected]>
> Subject: [Intel-wired-lan] [PATCH net-next 7/7] net/mlx5: Don't use %pK
> through tracepoints
>
> In the past %pK was preferable to %p as it would not leak raw pointer values
> into the kernel log.
> Since commit ad67b74d2469 ("printk: hash addresses printed with %p") the
> regular %p has been improved to avoid this issue.
> Furthermore, restricted pointers ("%pK") were never meant to be used
> through tracepoints. They can still unintentionally leak raw pointers or
> acquire
> sleeping looks in atomic contexts.
>
> Switch to the regular pointer formatting which is safer and easier to reason
> about.
> There are still a few users of %pK left, but these use it through seq_file,
> for
> which its usage is safe.
>
> Signed-off-by: Thomas Weißschuh <[email protected]>
Reviewed-by: Aleksandr Loktionov <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/sf/dev/diag/dev_tracepoint.h | 2
> +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/diag/dev_tracepoint.h
> b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/diag/dev_tracepoint.h
> index
> 0537de86f9817dc80bd897688c539135b1ad37ac..9b0f44253f332aa602a8
> 4a1f6d7532a500dd4f55 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/diag/dev_tracepoint.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/diag/dev_tracepoint
> +++ .h
> @@ -28,7 +28,7 @@ DECLARE_EVENT_CLASS(mlx5_sf_dev_template,
> __entry->hw_fn_id = sfdev->fn_id;
> __entry->sfnum = sfdev->sfnum;
> ),
> - TP_printk("(%s) sfdev=%pK aux_id=%d hw_id=0x%x
> sfnum=%u\n",
> + TP_printk("(%s) sfdev=%p aux_id=%d hw_id=0x%x
> sfnum=%u\n",
> __get_str(devname), __entry->sfdev,
> __entry->aux_id, __entry->hw_fn_id,
> __entry->sfnum)
>
> --
> 2.49.0
