On 5/14/2025 4:42 PM, Jakub Kicinski wrote:
On Wed, 14 May 2025 15:44:49 +0200 Szapar-Mudlaw, Martyna wrote:
The link-down events counter increments upon actual physical link-down
events, doesn't increment when user performs a simple down/up of the
interface.
However there is indeed link down event from firmware - as
part of interface reinitialization eg. when attaching XDP program,
reconfiguring channels and setting interface priv-flags.
Maybe I'm misunderstanding, but are you saying that the link-down
counter doesn't increment on ifdown+ifup but it does increment
when attaching an XDP prog?
The definition of link_down_events is pretty simple - (plus minus
the quantum world of signals) the link_down_events is physical link
downs which the switch / remote end will also see. Unlike software
carrier off which may just configure the MAC or the NIC pipeline to
drop but the PHY stays connected / trained / synchronized.
Agree. I said that it increments when physical link gets down and not
eg. when user performs ip link set dev eth down.
So this implementation of link_down_events counter is consistent with
the definition you provided.
Regards,
Martyna
