On 5/13/25 15:54, Dawid Osuchowski wrote:
On 2025-05-13 3:31 PM, Zilin Guan wrote:
If this change is required, should I submit it as a new standalone patch,
or include it in a v2 of the existing patch series?
I think you could include it with the v2, as it touches the same stack
SA structs (if you decide to reuse memzero_explicit() on them).
the general rule is to memzero_explicit() memory that was holding secure
content
--
to have full picture: it is fine to memset() such storage prior to use,
it is also fine to combine related changes in one commit/one series
re stated purpose of the patch:
I see @rsa cleaned in just one exit point of ixgbe_ipsec_add_sa(),
instead of all of them, so v2 seems warranted
