> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Jacob > Keller > Sent: 02 May 2025 04:24 > To: Intel Wired LAN <[email protected]>; Nguyen, Anthony L > <[email protected]>; netdev <[email protected]> > Cc: Keller, Jacob E <[email protected]>; Kubiak, Michal > <[email protected]>; Loktionov, Aleksandr > <[email protected]>; Kolacinski, Karol > <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Olech, Milena <[email protected]>; Paul > Menzel <[email protected]> > Subject: [Intel-wired-lan] [PATCH v4 15/15] ice: default to TIME_REF instead > of TXCO on E825-C > > The driver currently defaults to the internal oscillator as the clock source > for E825-C hardware. While this clock source is labeled TCXO, indicating a > temperature compensated oscillator, this is only true for some board designs. > Many board designs have a less capable oscillator. The E825-C hardware may > also have its clock source set to the TIME_REF pin. > This pin is connected to the DPLL and is often a more stable clock source. > The choice of the internal oscillator is not suitable for all systems, > especially those which want to enable SyncE support. > > There is currently no interface available for users to configure the clock > source. Other variants of the E82x board have the clock source configured in > the NVM, but E825-C lacks this capability, so different board designs cannot > select a different default clock via firmware. > > In most setups, the TIME_REF is a suitable default clock source. > Additionally, we now fall back to the internal oscillator automatically if > the TIME_REF clock source cannot be locked. > > Change the default clock source for E825-C to TIME_REF. Note that the driver > logs a dev_dbg message upon configuring the TSPLL which includes the clock > source and frequency. This can be enabled to confirm which clock source is in > use. > > Longterm a proper interface to dynamically introspect and change the clock > source will be designed (perhaps some extension of the DPLL subsystem?) > > Signed-off-by: Jacob Keller <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
