> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Jacob > Keller > Sent: 06 May 2025 01:44 > To: Intel Wired LAN <[email protected]>; Nguyen, Anthony L > <[email protected]>; netdev <[email protected]> > Cc: Keller, Jacob E <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Loktionov, Aleksandr > <[email protected]>; Simon Horman <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next v2 1/2] net: intel: rename 'hena' > to 'hashcfg' for clarity > > i40e, ice, and iAVF all use 'hena' as a shorthand for the "hash enable" configuration. This comes originally from the X710 datasheet 'xxQF_HENA' registers. In the context of the registers the meaning is fairly clear. > > However, on its own, hena is a weird name that can be more difficult to > understand. This is especially true in ice. The E810 hardware doesn't even > have registers with HENA in the name. > > Replace the shorthand 'hena' with 'hashcfg'. This makes it clear the > variables deal with the Hash configuration, not just a single boolean on/off > for all hashing. > > Do not update the register names. These come directly from the datasheet for > X710 and X722, and it is more important that the names can be searched. > > Suggested-by: Przemek Kitszel <[email protected]> > Reviewed-by: Aleksandr Loktionov <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > Reviewed-by: Simon Horman <[email protected]> > Signed-off-by: Jacob Keller <[email protected]> > --- > drivers/net/ethernet/intel/i40e/i40e_txrx.h | 8 ++-- > drivers/net/ethernet/intel/iavf/iavf.h | 10 ++--- > drivers/net/ethernet/intel/iavf/iavf_txrx.h | 4 +- > drivers/net/ethernet/intel/ice/ice_flow.h | 4 +- > drivers/net/ethernet/intel/ice/ice_virtchnl.h | 4 +- > include/linux/avf/virtchnl.h | 22 +++++------ > drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- > drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 46 +++++++++++----------- > drivers/net/ethernet/intel/iavf/iavf_main.c | 17 ++++---- > drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 33 ++++++++-------- > drivers/net/ethernet/intel/ice/ice_lib.c | 2 +- > drivers/net/ethernet/intel/ice/ice_virtchnl.c | 44 ++++++++++----------- > .../ethernet/intel/ice/ice_virtchnl_allowlist.c | 2 +- > 13 files changed, 101 insertions(+), 97 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
