> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Simon > Horman > Sent: Monday, April 28, 2025 2:44 PM > To: Marcin Szycik <[email protected]> > Cc: [email protected]; [email protected]; Zaki, Ahmed > <[email protected]>; Kitszel, Przemyslaw <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-net] iavf: fix reset_task for early > reset > event > > On Thu, Apr 24, 2025 at 03:50:13PM +0200, Marcin Szycik wrote: > > From: Ahmed Zaki <[email protected]> > > > > If a reset event is received from the PF early in the init cycle, the > > state machine hangs for about 25 seconds. > > > > Reproducer: > > echo 1 > /sys/class/net/$PF0/device/sriov_numvfs > > ip link set dev $PF0 vf 0 mac $NEW_MAC > > > > The log shows: > > [792.620416] ice 0000:5e:00.0: Enabling 1 VFs > > [792.738812] iavf 0000:5e:01.0: enabling device (0000 -> 0002) > > [792.744182] ice 0000:5e:00.0: Enabling 1 VFs with 17 vectors and 16 > > queues > per VF > > [792.839964] ice 0000:5e:00.0: Setting MAC 52:54:00:00:00:11 on VF 0. VF > driver will be reinitialized > > [813.389684] iavf 0000:5e:01.0: Failed to communicate with PF; waiting > before retry > > [818.635918] iavf 0000:5e:01.0: Hardware came out of reset. Attempting > reinit. > > [818.766273] iavf 0000:5e:01.0: Multiqueue Enabled: Queue pair count > > = 16 > > > > Fix it by scheduling the reset task and making the reset task capable > > of resetting early in the init cycle. > > > > Fixes: ef8693eb90ae3 ("i40evf: refactor reset handling") > > Signed-off-by: Ahmed Zaki <[email protected]> > > Tested-by: Przemek Kitszel <[email protected]> > > Reviewed-by: Przemek Kitszel <[email protected]> > > Signed-off-by: Marcin Szycik <[email protected]> > > --- > > This should be applied after "iavf: get rid of the crit lock" > > Reviewed-by: Simon Horman <[email protected]>
Tested-by: Rafal Romanowski <[email protected]>
