> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Michal > Kubiak > Sent: Thursday, May 15, 2025 11:47 AM > To: Keller, Jacob E <[email protected]> > Cc: [email protected]; Fijalkowski, Maciej > <[email protected]>; [email protected]; Kitszel, Przemyslaw > <[email protected]>; [email protected]; Nguyen, Anthony L > <[email protected]>; Swiatkowski, Michal > <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: add a separate Rx > handler > for flow director commands > > On Wed, May 14, 2025 at 01:50:22PM -0700, Jacob Keller wrote: > > > > > > On 5/14/2025 5:37 AM, Michal Kubiak wrote: > > > The "ice" driver implementation uses the control VSI to handle the > > > flow director configuration for PFs and VFs. > > > > > > Unfortunately, although a separate VSI type was created to handle > > > flow director queues, the Rx queue handler was shared between the > > > flow director and a standard NAPI Rx handler. > > > > > > Such a design approach was not very flexible. First, it mixed > > > hotpath and slowpath code, blocking their further optimization. It > > > also created a huge overkill for the flow director command > > > processing, which is descriptor-based only, so there is no need to > > > allocate Rx > data buffers. > > > > > > For the above reasons, implement a separate Rx handler for the > > > control VSI. Also, remove from the NAPI handler the code dedicated > > > to configuring the flow director rules on VFs. > > > Do not allocate Rx data buffers to the flow director queues because > > > their processing is descriptor-based only. > > > Finally, allow Rx data queues to be allocated only for VSIs that > > > have netdev assigned to them.
Tested-by: Rafal Romanowski <[email protected]>
