On Mon, Jun 16, 2025 at 03:36:36PM +0200, Jedrzej Jagielski wrote:
> Currently aci.lock is initialized too late. A bunch of ACI callbacks
> using the lock are called prior it's initialized.
>
> Commit 337369f8ce9e ("locking/mutex: Add MUTEX_WARN_ON() into fast path")
> highlights that issue what results in call trace.
>
> [ 4.092899] DEBUG_LOCKS_WARN_ON(lock->magic != lock)
> [ 4.092910] WARNING: CPU: 0 PID: 578 at kernel/locking/mutex.c:154
> mutex_lock+0x6d/0x80
> [ 4.098757] Call Trace:
> [ 4.098847] <TASK>
> [ 4.098922] ixgbe_aci_send_cmd+0x8c/0x1e0 [ixgbe]
> [ 4.099108] ? hrtimer_try_to_cancel+0x18/0x110
> [ 4.099277] ixgbe_aci_get_fw_ver+0x52/0xa0 [ixgbe]
> [ 4.099460] ixgbe_check_fw_error+0x1fc/0x2f0 [ixgbe]
> [ 4.099650] ? usleep_range_state+0x69/0xd0
> [ 4.099811] ? usleep_range_state+0x8c/0xd0
> [ 4.099964] ixgbe_probe+0x3b0/0x12d0 [ixgbe]
> [ 4.100132] local_pci_probe+0x43/0xa0
> [ 4.100267] work_for_cpu_fn+0x13/0x20
> [ 4.101647] </TASK>
>
> Move aci.lock mutex initialization to ixgbe_sw_init() before any ACI
> command is sent. Along with that move also related SWFW semaphore in
> order to reduce size of ixgbe_probe() and that way all locks are
> initialized in ixgbe_sw_init().
>
> Reviewed-by: Michal Swiatkowski <[email protected]>
> Reviewed-by: Przemek Kitszel <[email protected]>
> Fixes: 4600cdf9f5ac ("ixgbe: Enable link management in E610 device")
> Signed-off-by: Jedrzej Jagielski <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
