> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Song Yoong Siang
> Sent: Friday, June 20, 2025 12:03 PM
> To: Nguyen, Anthony L <[email protected]>; David S . Miller
> <[email protected]>; Eric Dumazet <[email protected]>; Jakub
> Kicinski <[email protected]>; Paolo Abeni <[email protected]>; Richard
> Cochran <[email protected]>; Alexei Starovoitov
> <[email protected]>; Daniel Borkmann <[email protected]>; Jesper
> Dangaard Brouer <[email protected]>; John Fastabend
> <[email protected]>; Gomes, Vinicius
> <[email protected]>; Jonathan Corbet <[email protected]>; Kitszel,
> Przemyslaw <[email protected]>; Shinas Rasheed
> <[email protected]>; Tian, Kevin <[email protected]>; Brett
> Creeley <[email protected]>; Blanco Alcaine, Hector
> <[email protected]>; Hay, Joshua A
> <[email protected]>; Andrew Lunn <[email protected]>; Keller,
> Jacob E <[email protected]>; Kurt Kanzenbach
> <[email protected]>; Marcin Szycik <[email protected]>;
> Brett Creeley <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]
> Subject: [Intel-wired-lan] [PATCH iwl-next, v3 1/2] igc: Relocate RSS
> field definitions to igc_defines.h
>
> Move the RSS field definitions related to IPv4 and IPv6 UDP from igc.h
> to igc_defines.h to consolidate the RSS field definitions in a single
> header file, improving code organization and maintainability.
>
> This refactoring does not alter the functionality of the driver but
> enhances the logical grouping of related constants
>
> Reviewed-by: Kurt Kanzenbach <[email protected]>
> Signed-off-by: Song Yoong Siang <[email protected]>
Reviewed-by: Aleksandr Loktionov <[email protected]>
> ---
> drivers/net/ethernet/intel/igc/igc.h | 4 ----
> drivers/net/ethernet/intel/igc/igc_defines.h | 3 +++
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc.h
> b/drivers/net/ethernet/intel/igc/igc.h
> index 1525ae25fd3e..0b35e593d5ee 100644
> --- a/drivers/net/ethernet/intel/igc/igc.h
> +++ b/drivers/net/ethernet/intel/igc/igc.h
> @@ -406,10 +406,6 @@ extern char igc_driver_name[];
> #define IGC_FLAG_RSS_FIELD_IPV4_UDP BIT(6)
> #define IGC_FLAG_RSS_FIELD_IPV6_UDP BIT(7)
>
> -#define IGC_MRQC_ENABLE_RSS_MQ 0x00000002
> -#define IGC_MRQC_RSS_FIELD_IPV4_UDP 0x00400000
> -#define IGC_MRQC_RSS_FIELD_IPV6_UDP 0x00800000
> -
> /* RX-desc Write-Back format RSS Type's */ enum igc_rss_type_num {
> IGC_RSS_TYPE_NO_HASH = 0,
> diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h
> b/drivers/net/ethernet/intel/igc/igc_defines.h
> index 86b346687196..d80254f2a278 100644
> --- a/drivers/net/ethernet/intel/igc/igc_defines.h
> +++ b/drivers/net/ethernet/intel/igc/igc_defines.h
> @@ -383,11 +383,14 @@
> #define IGC_RXDEXT_STATERR_IPE 0x40000000
> #define IGC_RXDEXT_STATERR_RXE 0x80000000
>
> +#define IGC_MRQC_ENABLE_RSS_MQ 0x00000002
> #define IGC_MRQC_RSS_FIELD_IPV4_TCP 0x00010000
> #define IGC_MRQC_RSS_FIELD_IPV4 0x00020000
> #define IGC_MRQC_RSS_FIELD_IPV6_TCP_EX 0x00040000
> #define IGC_MRQC_RSS_FIELD_IPV6 0x00100000
> #define IGC_MRQC_RSS_FIELD_IPV6_TCP 0x00200000
> +#define IGC_MRQC_RSS_FIELD_IPV4_UDP 0x00400000
> +#define IGC_MRQC_RSS_FIELD_IPV6_UDP 0x00800000
>
> /* Header split receive */
> #define IGC_RFCTL_IPV6_EX_DIS 0x00010000
> --
> 2.34.1
