On Tue, Jul 08, 2025 at 10:17:22AM +0200, Jacek Kowalski wrote: > Remove unnecessary casts of constant values to u16. > Let the C type system do it's job. > > Signed-off-by: Jacek Kowalski <ja...@jacekk.info> > Suggested-by: Simon Horman <ho...@kernel.org>
The nit below not withstanding this looks good to me. Reviewed-by: Simon Horman <ho...@kernel.org> > --- > drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +- > drivers/net/ethernet/intel/e1000e/nvm.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c > b/drivers/net/ethernet/intel/e1000e/ethtool.c > index c0bbb12eed2e..5d8c66253779 100644 > --- a/drivers/net/ethernet/intel/e1000e/ethtool.c > +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c > @@ -959,7 +959,7 @@ static int e1000_eeprom_test(struct e1000_adapter > *adapter, u64 *data) > } > > /* If Checksum is not Correct return error else test passed */ > - if ((checksum != (u16)NVM_SUM) && !(*data)) > + if ((checksum != NVM_SUM) && !(*data)) Unnecessary inner parentheses here too. ...
