> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf
> Of Simon Horman
> Sent: Thursday, July 10, 2025 12:25 PM
> To: Markus Blöchl <mar...@blochl.de>
> Cc: Nguyen, Anthony L <anthony.l.ngu...@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kits...@intel.com>; Richard Cochran
> <richardcoch...@gmail.com>; Thomas Gleixner <t...@linutronix.de>;
> Lakshmi Sowjanya D <lakshmi.sowjany...@intel.com>; Andrew Lunn
> <andrew+net...@lunn.ch>; David S. Miller <da...@davemloft.net>; Eric
> Dumazet <eduma...@google.com>; Jakub Kicinski <k...@kernel.org>; Paolo
> Abeni <pab...@redhat.com>; Bloechl, Markus
> <markus.bloe...@ipetronik.com>; John Stultz <jstu...@google.com>;
> intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH v2] e1000e: Populate entire
> system_counterval_t in get_time_fn() callback
>
> On Wed, Jul 09, 2025 at 07:28:07PM +0200, Markus Blöchl wrote:
> > get_time_fn() callback implementations are expected to fill out the
> > entire system_counterval_t struct as it may be initially
> uninitialized.
> >
> > This broke with the removal of convert_art_to_tsc() helper functions
> > which left use_nsecs uninitialized.
> >
> > Assign the entire struct again.
> >
> > Fixes: bd48b50be50a ("e1000e: Replace convert_art_to_tsc()")
> > Cc: sta...@vger.kernel.org
> > Signed-off-by: Markus Blöchl <mar...@blochl.de>
> > ---
> > Notes:
> > Related-To:
> >
> <https://lore.kernel.org/lkml/txyrr26hxe3xpq3ebqb5ewkgvhvp7xalotaouwlu
> > djtjifnah2@7tmgczln4aoo/>
> >
> > Changes in v2:
> > - Add Lakshmi in Cc:
> > - Add Signed-off-by: trailer which was lost in b4 workflow
> > - Link to v1:
> > https://lore.kernel.org/r/20250709-e1000e_crossts-v1-1-
> f8a80c792e4f@bl
> > ochl.de
>
> Reviewed-by: Simon Horman <ho...@kernel.org>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktio...@intel.com>