From: Przemek Kitszel <przemyslaw.kits...@intel.com> Date: Fri, 11 Jul 2025 12:25:09 +0200
> On 7/11/25 08:47, Malin Jonsson wrote: >> The idpf driver depends on both AUXILIARY_BUS and NET_DEVLINK, but >> they're not selected by the Kconfig. Let's fix this so idpf builds even >> with a stripped config. >> >> Reported-by: Yong Gu <yong.g...@ericsson.com> >> Signed-off-by: Malin Jonsson <malin.jons...@est.tech> > > Thank you for the fix! > if you have a Link to the public report, please add it as a Closes: tag > > Would be also great to add a Fixes: tag with the commit that introduces > the need for given dependency/ies > (there should be one tag only (per your commit), if both deps were > introduced by the very same pull request, just use the earlier commit) > >> --- >> drivers/net/ethernet/intel/idpf/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/ethernet/intel/idpf/Kconfig b/drivers/net/ >> ethernet/intel/idpf/Kconfig >> index 1f893221e2c99..5c7ce626aae16 100644 >> --- a/drivers/net/ethernet/intel/idpf/Kconfig >> +++ b/drivers/net/ethernet/intel/idpf/Kconfig >> @@ -8,6 +8,8 @@ config IDPF >> select LIBETH >> select LIBETH_CP >> select LIBETH_IRQ >> + select AUXILIARY_BUS >> + select NET_DEVLINK Uhm, idpf currently uses neither of those... Could you give a real output with the linker being unable to resolve auxbus and/or devlink symbols for idpf.ko? > > looks good, but please notice that we keep this list sorted > >> help >> This driver supports Intel(R) Infrastructure Data Path Function >> devices. Thanks, Olek
