> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Michal Swiatkowski
> Sent: Tuesday, July 22, 2025 12:46 PM
> To: [email protected]
> Cc: [email protected]; Kitszel, Przemyslaw
> <[email protected]>; [email protected];
> Michal Swiatkowski <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1 01/15] ice: make fwlog
> functions static
>
> ice_fwlog_supported(), ice_fwlog_get() and ice_fwlog_supported()
> aren't called outside the ice_fwlog.c file. Make it static and move in
> the file to allow clean build.
>
> Drop ice_fwlog_get(). It is called only from ice_fwlog_init() function
> where the fwlog support is already checked. There is no need to check
> it again, call ice_aq_fwlog_get() instead.
>
> Drop no longer valid comment from ice_fwlog_get_supported().
>
> Reviewed-by: Przemek Kitszel <[email protected]>
> Signed-off-by: Michal Swiatkowski <[email protected]>
Reviewed-by: Aleksandr Loktionov <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_fwlog.c | 232 ++++++++++----------
> -
> drivers/net/ethernet/intel/ice/ice_fwlog.h | 5 +-
> 2 files changed, 109 insertions(+), 128 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_fwlog.c
> b/drivers/net/ethernet/intel/ice/ice_fwlog.c
> index a31bb026ad34..e48856206648 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fwlog.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fwlog.c
> @@ -123,6 +123,113 @@ void ice_fwlog_realloc_rings(struct ice_hw *hw,
> int index)
> hw->fwlog_ring.tail = 0;
> }
>
