On Tue, Jul 22, 2025 at 03:54:28PM +0100, Simon Horman wrote:
> On Tue, Jul 22, 2025 at 12:45:54PM +0200, Michal Swiatkowski wrote:
> > In debugfs pass ice_fwlog structure instead of ice_pf.
> >
> > The debgufs dirs specific for fwlog can be stored in fwlog structure.
> >
> > Add debugfs entry point to fwlog api.
> >
> > Reviewed-by: Przemek Kitszel <[email protected]>
> > Signed-off-by: Michal Swiatkowski <[email protected]>
>
> ...
>
> > diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c
> > b/drivers/net/ethernet/intel/ice/ice_debugfs.c
>
> ...
>
> > @@ -580,9 +569,10 @@ static const struct file_operations
> > ice_debugfs_data_fops = {
> >
> > /**
> > * ice_debugfs_fwlog_init - setup the debugfs directory
> > - * @pf: the ice that is starting up
> > + * @fwlog: pointer to the fwlog structure
> > + * @root: debugfs root entry on which fwlog director will be registered
> > */
> > -void ice_debugfs_fwlog_init(struct ice_pf *pf)
> > +void ice_debugfs_fwlog_init(struct ice_fwlog *fwlog, struct dentry *root)
> > {
> > struct dentry *fw_modules_dir;
> > struct dentry **fw_modules;
> > @@ -598,41 +588,39 @@ void ice_debugfs_fwlog_init(struct ice_pf *pf)
> >
> > pf->ice_debugfs_pf_fwlog = debugfs_create_dir("fwlog",
> > pf->ice_debugfs_pf);
>
> pf no longer exists in this context.
>
Right, sorry, I missed that. I will build check each commit before
sending v2.
Thanks
> > - if (IS_ERR(pf->ice_debugfs_pf_fwlog))
> > + if (IS_ERR(fwlog->debugfs))
> > goto err_create_module_files;
> >
> > - fw_modules_dir = debugfs_create_dir("modules",
> > - pf->ice_debugfs_pf_fwlog);
> > + fw_modules_dir = debugfs_create_dir("modules", fwlog->debugfs);
> > if (IS_ERR(fw_modules_dir))
> > goto err_create_module_files;
>
> ...
