On 11/08/2025 16:41, Jakub Kicinski wrote:
On Sun, 10 Aug 2025 11:52:55 +0100 Vadim Fedorenko wrote:
TBH I'm a bit unsure if this is really worth breaking out into
individual nla_puts(). We generally recommend that, but here it's
an array of simple ints.. maybe we're better of with a binary / C
array of u64. Like the existing FEC stats but without also folding
the total value into index 0.
Well, the current implementation is straight forward. Do you propose to
have drivers fill in the amount of lanes they have histogram for, or
should we always put array of ETHTOOL_MAX_LANES values and let
user-space to figure out what to show?
Similar logic to what you have, you can move the put outside of the
loop, let the loop break or exit, and then @j will tell you how many
entries to fill..
I see. Fair, I can do it. After this change there will be no need to
change the code in the reply size calculation, right?
