> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Jedrzej Jagielski > Sent: 31 July 2025 18:16 > To: [email protected] > Cc: Nguyen, Anthony L <[email protected]>; [email protected]; > Jagielski, Jedrzej <[email protected]>; Loktionov, Aleksandr > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net v2] ixgbe: fix ixgbe_orom_civd_info > struct layout > > The current layout of struct ixgbe_orom_civd_info causes incorrect data > storage due to compiler-inserted padding. This results in issues when writing > OROM data into the structure. > > Add the __packed attribute to ensure the structure layout matches the > expected binary format without padding. > > Fixes: 70db0788a262 ("ixgbe: read the OROM version information") > Reviewed-by: Aleksandr Loktionov <[email protected]> > Signed-off-by: Jedrzej Jagielski <[email protected]> > --- > v2: use get_unaligned_le32() per Simon's suggestion > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 2 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_type_e610.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
