> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Kohei > Enju > Sent: 15 August 2025 11:57 > To: [email protected]; [email protected] > Cc: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Andrew Lunn <[email protected]>; David S. > Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub > Kicinski <[email protected]>; Paolo Abeni <[email protected]>; Alexander Duyck > <[email protected]>; [email protected]; Kohei Enju > <[email protected]> > Subject: [Intel-wired-lan] [PATCH v1 iwl-net] igb: fix link test skipping > when interface is admin down > > The igb driver incorrectly skips the link test when the network interface is > admin down (if_running == false), causing the test to always report PASS > regardless of the actual physical link state. > > This behavior is inconsistent with other drivers (e.g. i40e, ice, ixgbe, etc.) which correctly test the physical link state regardless of admin state. > Remove the if_running check to ensure link test always reflects the physical > link state. > > Fixes: 8d420a1b3ea6 ("igb: correct link test not being run when link is down") > Signed-off-by: Kohei Enju <[email protected]> > --- > drivers/net/ethernet/intel/igb/igb_ethtool.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
