> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of [email protected]
> Sent: Friday, September 5, 2025 4:55 AM
> To: Nguyen, Anthony L <[email protected]>; Kitszel,
> Przemyslaw <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; Qiang Liu <[email protected]>
> Subject: [Intel-wired-lan] [PATCH] ixgbe: Remove self-assignment
> code
>
> From: Qiang Liu <[email protected]>
>
> After obtaining the register value via raw_desc,
> redundant self-assignment operations can be removed.
>
> Signed-off-by: Qiang Liu <[email protected]>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index bfeef5b0b99d..6efedf04a963 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct
> ixgbe_hw *hw,
>
> /* Read sync Admin Command response */
> if ((hicr & IXGBE_PF_HICR_SV)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw,
> IXGBE_PF_HIDA(i));
> - raw_desc[i] = raw_desc[i];
> - }
> }
>
> /* Read async Admin Command response */
> if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
> - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
> + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
> raw_desc[i] = IXGBE_READ_REG(hw,
> IXGBE_PF_HIDA_2(i));
> - raw_desc[i] = raw_desc[i];
> - }
Can you refactor it to use IXGBE_READ_REG_ARRAY(hw, REG, i)?
this can greatly improve readability!
> }
>
> /* Handle timeout and invalid state of HICR register */
> --
> 2.43.0
