Hi Vadim,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    
https://github.com/intel-lab-lkp/linux/commits/Vadim-Fedorenko/ethtool-add-FEC-bins-histogramm-report/20250910-025057
base:   net-next/main
patch link:    
https://lore.kernel.org/r/20250909184216.1524669-4-vadim.fedorenko%40linux.dev
patch subject: [PATCH net-next 3/4] net/mlx5e: Add logic to read RS-FEC 
histogram bin ranges from PPHCR
config: i386-buildonly-randconfig-002-20250910 
(https://download.01.org/0day-ci/archive/20250910/[email protected]/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20250910/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

   In file included from arch/x86/include/asm/string.h:3,
                    from arch/x86/include/asm/cpuid/api.h:10,
                    from arch/x86/include/asm/processor.h:19,
                    from include/linux/sched.h:13,
                    from drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h:38,
                    from drivers/net/ethernet/mellanox/mlx5/core/lib/events.h:7,
                    from drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:33:
   drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 
'fec_rs_histogram_fill_ranges':
>> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1505:43: warning: 
>> argument to 'sizeof' in '__builtin_memset' call is the same expression as 
>> the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]
    1505 |         memset(priv->fec_ranges, 0, sizeof(priv->fec_ranges));
         |                                           ^
   arch/x86/include/asm/string_32.h:194:52: note: in definition of macro 
'memset'
     194 | #define memset(s, c, count) __builtin_memset(s, c, count)
         |                                                    ^~~~~


vim +1505 drivers/net/ethernet/mellanox/mlx5/core/en_stats.c

  1494  
  1495  static u8
  1496  fec_rs_histogram_fill_ranges(struct mlx5e_priv *priv,
  1497                               const struct ethtool_fec_hist_range 
**ranges)
  1498  {
  1499          struct mlx5_core_dev *mdev = priv->mdev;
  1500          u32 out[MLX5_ST_SZ_DW(pphcr_reg)] = {0};
  1501          u32 in[MLX5_ST_SZ_DW(pphcr_reg)] = {0};
  1502          int sz = MLX5_ST_SZ_BYTES(pphcr_reg);
  1503          u8 active_hist_type, num_of_bins;
  1504  
> 1505          memset(priv->fec_ranges, 0, sizeof(priv->fec_ranges));
  1506          MLX5_SET(pphcr_reg, in, local_port, 1);
  1507          if (mlx5_core_access_reg(mdev, in, sz, out, sz, MLX5_REG_PPHCR, 
0, 0))
  1508                  return 0;
  1509  
  1510          active_hist_type = MLX5_GET(pphcr_reg, out, active_hist_type);
  1511          if (!active_hist_type)
  1512                  return 0;
  1513  
  1514          num_of_bins = MLX5_GET(pphcr_reg, out, num_of_bins);
  1515          if (WARN_ON_ONCE(num_of_bins > MLX5E_FEC_RS_HIST_MAX))
  1516                  return 0;
  1517  
  1518          for (u8 i = 0; i < num_of_bins; i++) {
  1519                  void *bin_range = MLX5_ADDR_OF(pphcr_reg, out, 
bin_range[i]);
  1520  
  1521                  priv->fec_ranges[i].high = MLX5_GET(bin_range_layout, 
bin_range,
  1522                                                      high_val);
  1523                  priv->fec_ranges[i].low = MLX5_GET(bin_range_layout, 
bin_range,
  1524                                                     low_val);
  1525          }
  1526          *ranges = priv->fec_ranges;
  1527  
  1528          return num_of_bins;
  1529  }
  1530  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Reply via email to