On 10/23/2025 9:05 PM, Alexander Lobakin wrote:
@@ -940,7 +940,7 @@ static int idpf_rx_desc_alloc_all(struct idpf_vport *vport)
                        if (err) {
                                pci_err(vport->adapter->pdev,
                                        "Memory allocation for Rx Buffer Queue %u 
failed\n",
-                                       i);
+                                       j);
                                goto err_out;
Both are not valid.

@i is the index of the queue group. @j is the index of the queue
*inside* this queue group.
Since one queue group can contain only one Rx queue and 2 buffer queues,
these pci_err() would only print "Rx queue 0" and "Rx Buffer Queue 0/1",
which is even less useful than before.

If you want to "fix" this, you can print rxq->idx for Rx queues and
`(i * vport->num_bufqs_per_qgrp) + j` for buffer queues. This would
at least print unique index for each queue.

Alternatively, expand the message to something like:

"Memory allocation for Rx queue %u from queue group %u failed\n", j, i);

(same for buffer queues)

                        }
                }

Thanks, Alexander. I will send v3 with both the Rx queue and queue group(j, i).

Thanks
Alok

Reply via email to