> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Przemek Kitszel > Sent: Wednesday, November 5, 2025 11:14 > To: Michal Swiatkowski <[email protected]> > Cc: Paul Menzel <[email protected]>; [email protected]; > [email protected]; Lobakin, Aleksander <[email protected]>; > Keller, Jacob E <[email protected]>; Loktionov, Aleksandr > <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: use > netif_get_num_default_rss_queues() > > On 10/31/25 14:17, Michal Swiatkowski wrote: > > On Thu, Oct 30, 2025 at 11:39:30AM +0100, Przemek Kitszel wrote: > >> On 10/30/25 10:37, Michal Swiatkowski wrote: > >>> On Thu, Oct 30, 2025 at 10:10:32AM +0100, Paul Menzel wrote: > >>>> Dear Michal, > >>>> > >>>> > >>>> Thank you for your patch. For the summary, I’d add: > >>>> > >>>> ice: Use netif_get_num_default_rss_queues() to decrease queue > >>>> number > >> > >> I would instead just say: > >> ice: cap the default number of queues to 64 > >> > >> as this is exactly what happens. Then next paragraph could be: > >> Use netif_get_num_default_rss_queues() as a better base (instead of > >> the number of CPU cores), but still cap it to 64 to avoid excess IRQs > >> assigned to PF (what would leave, in some cases, nothing for VFs). > >> > >> sorry for such late nitpicks > >> and, see below too > > > > I moved away from capping to 64, now it is just call to > > netif_get_num_default_rss_queues(). Following Olek's comment, dividing > > by 2 is just fine now and looks like there is no good reasone to cap > > it more in the driver, but let's discuss it here if you have different > > opinion. > > I see, sorry for the confusion > with that I'm fine with the change being -next material, and commit message is > good (not sure if perfect, but it does not need to be) > Reviewed-by: Przemek Kitszel <[email protected]> > > > > >> > >>>>
Tested-by: Rafal Romanowski <[email protected]>
