> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Joshi, Sreedevi
> Sent: Friday, November 28, 2025 3:31 PM
> To: Simon Horman <[email protected]>
> Cc: [email protected]; [email protected]; Loktionov,
> Aleksandr <[email protected]>; Samudrala, Sridhar
> <[email protected]>; Tantilov, Emil S <[email protected]>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 2/3] idpf: Fix RSS LUT
> configuration on down interfaces
>
> > -----Original Message-----
> > From: Simon Horman <[email protected]>
> > Sent: Thursday, November 27, 2025 6:45 AM
> > To: Joshi, Sreedevi <[email protected]>
> > Cc: [email protected]; [email protected];
> > Loktionov, Aleksandr <[email protected]>; Samudrala,
> > Sridhar <[email protected]>; Tantilov, Emil S
> > <[email protected]>
> > Subject: Re: [PATCH iwl-net v2 2/3] idpf: Fix RSS LUT configuration on
> > down interfaces
> >
> > On Mon, Nov 24, 2025 at 12:47:49PM -0600, Sreedevi Joshi wrote:
> > > RSS LUT provisioning and queries on a down interface currently
> > > return silently without effect. Users should be able to configure
> > > RSS settings even when the interface is down.
> > >
> > > Fix by maintaining RSS configuration changes in the driver's soft
> > > copy and deferring HW programming until the interface comes up.
> > >
> > > Fixes: 02cbfba1add5 ("idpf: add ethtool callbacks")
> > > Signed-off-by: Sreedevi Joshi <[email protected]>
> > > Reviewed-by: Aleksandr Loktionov <[email protected]>
> > > Reviewed-by: Sridhar Samudrala <[email protected]>
> > > Reviewed-by: Emil Tantilov <[email protected]>
> > > ---
> > > drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 17
> > > +++++++++++------
> > > 1 file changed, 11 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
> > > b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
> >
> > ...
> >
> > > @@ -424,7 +429,7 @@ static int idpf_get_rxfh(struct net_device
> > > *netdev,
> > >
> > > if (rxfh->indir) {
> > > for (i = 0; i < rss_data->rss_lut_size; i++)
> > > - rxfh->indir[i] = rss_data->rss_lut[i];
> > > + rxfh->indir[i] = rxhash_ena ? rss_data->rss_lut[i] : 0;
> >
> > Hi,
> >
> > I feel that I am missing something here.
> > But I would have expected rxfh->indir to be populated by
> > rss_data->rss_lut regardless of the port is up or down. IOW, I'm
> > unclear on why
> > 0 is reported for the indirection table if the interface is down.
> >
> Interface being up/down does not affect filling out the rxfh->indir[]. User
> will
> be able to setup the indirection table even when interface is down and query
> the table as well (changes are cached in driver's copy and setup in HW when
> interface is brought up). However, when the rxhash is disabled on the
> interface, the indirection table has no effect, and it is programmed with
> zeros
> in the HW and returning all zeros in rxfh->indir[] here reflects that state.
> Thanks for your review, Simon!
> Regards,
> Sreedevi
> > > }
> > >
> > > unlock_mutex:
> >
> > ...
Tested-by: Samuel Salin <[email protected]>
