On 12/12/2025 1:06 PM, [email protected] wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
From: Gregory Herrero <[email protected]>
On code inspection, I realized we may want to check ring_len parameter
against hardware specific values in i40e_config_vsi_tx_queue() and
i40e_config_vsi_rx_queue().
v5:
- use "hardware-dependent" in commit description
- add Tested-by: Rafal Romanowski <[email protected]>
- get rid of i40e_get_max_num_descriptors() documentation as it's self
explanatory
v4:
- remove u32 cast in i40e_config_vsi_tx_queue() too and don't mention it
anymore in commit description.
- wrap i40e_get_max_num_descriptors() description
v3:
- drop trailing period from the subject
- reword commit description
- remove u32 cast in i40e_config_vsi_rx_queue()
v2:
- make i40e_get_max_num_descriptors() 'pf' argument const.
- reword i40e_get_max_num_descriptors() description.
- modify commit description to explain potential behavior change.
Gregory Herrero (1):
i40e: validate ring_len parameter against hardware-specific values
drivers/net/ethernet/intel/i40e/i40e.h | 11 +++++++++++
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 12 ------------
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 4 ++--
3 files changed, 13 insertions(+), 14 deletions(-)
Sorry I didn't notice this before, but I'm not used to seeing a cover
letter for a single patch. Usually (always?) cover letters are only used
for series (2 or more patches).
Thanks,
Brett
--
2.51.0
