On Sat, Jan 10, 2026 at 12:36 AM Paul Menzel <[email protected]> wrote: > > Dear Mina, > > > Thank you for your patch. Some minor comments, should you resend. >
Thanks, looks like I have reviews and this is on its way, but should I resend I will fix the minor comments. > Am 23.12.25 um 20:46 schrieb Mina Almasry via Intel-wired-lan: > > From: YiFei Zhu <[email protected]> > > > > The logic is similar to idpf_rx_hwtstamp, but the data is exported > > as a BPF kfunc instead of appended to an skb to support grabbing > > timestamps in xsk packets. > > > > A idpf_queue_has(PTP, rxq) condition is added to check the queue > > supports PTP similar to idpf_rx_process_skb_fields. > > > > Tested using an xsk connection and checking xdp timestamps are > > retreivable in received packets. > > retr*ie*vable > > It’d be great if you could share the commands. > I don't have easy repro to share in the commit message. The test involves hacking up the xsk_rr Sami used for his busypolling patch to enable xdp metadata and retrieve timestamps, or (what I did) actually set up openonload with this patch and test onload can get the timestamps. Let me see what I can do, but it's likely too much context for someone unfamiliar to piece together. -- Thanks, Mina
