> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > [email protected] > Sent: 29 December 2025 01:10 > To: [email protected] > Cc: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; [email protected]; [email protected]; > [email protected]; [email protected]; Keller, Jacob E > <[email protected]>; [email protected]; Mohammad Heib > <[email protected]>; Loktionov, Aleksandr <[email protected]>; > Paul Menzel <[email protected]> > Subject: [Intel-wired-lan] [PATCH net v3 1/2] i40e: drop > udp_tunnel_get_rx_info() call from i40e_open() > > From: Mohammad Heib <[email protected]> > > The i40e driver calls udp_tunnel_get_rx_info() during i40e_open(). > This is redundant because UDP tunnel RX offload state is preserved across > device down/up cycles. The udp_tunnel core handles synchronization > automatically when required. > > Furthermore, recent changes in the udp_tunnel infrastructure require querying > RX info while holding the udp_tunnel lock. Calling it directly from the > ndo_open path violates this requirement, triggering the following lockdep > warning: > > Call Trace: > <TASK> > ? __udp_tunnel_nic_assert_locked+0x39/0x40 [udp_tunnel] > i40e_open+0x135/0x14f [i40e] > __dev_open+0x121/0x2e0 > __dev_change_flags+0x227/0x270 > dev_change_flags+0x3d/0xb0 > devinet_ioctl+0x56f/0x860 > sock_do_ioctl+0x7b/0x130 > __x64_sys_ioctl+0x91/0xd0 > do_syscall_64+0x90/0x170 > ... > </TASK> > > Remove the redundant and unsafe call to udp_tunnel_get_rx_info() from > i40e_open() resolve the locking violation. > > Fixes: 1ead7501094c ("udp_tunnel: remove rtnl_lock dependency") > Signed-off-by: Mohammad Heib <[email protected]> > Reviewed-by: Aleksandr Loktionov <[email protected]> > Reviewed-by: Paul Menzel <[email protected]> > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 1 - > 1 file changed, 1 deletion(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
