> From: Simon Horman <[email protected]> > To: [email protected] > Cc: Simon Horman <[email protected]>, > [email protected], [email protected], > [email protected], [email protected], > [email protected], [email protected], > [email protected], [email protected], [email protected], > [email protected], [email protected], > [email protected], [email protected] > Subject: Re: [iwl-next,v5,3/3] igb: allow configuring RSS key via ethtool > set_rxfh > Date: Mon, 2 Feb 2026 10:25:20 +0000 [thread overview] > Message-ID: <[email protected]> (raw) > In-Reply-To: <[email protected]> > > This is an AI-generated review of your patch. The human sending this > email says "I'm releasing this report for completeness. And while I > do think it is correct. I don't think it needs to block progress" > > For local reproduction steps see > https://netdev-ai.bots.linux.dev/ai-local.html > --- > igb: allow configuring RSS key via ethtool set_rxfh > > This patch adds support for configuring the RSS key via ethtool's > set_rxfh interface. The change accepts a userspace-provided RSS key, > stores it in the adapter structure, and writes it to hardware registers. > > > Change igc_set_rxfh() to accept and save a userspace-provided > > RSS key. > > This isn't a code bug, but the commit message references "igc_set_rxfh()" > when the function being modified is actually igb_set_rxfh() in > drivers/net/ethernet/intel/igb/igb_ethtool.c. This typo was noted by > Aleksandr Loktionov in the v1 review: > https://lore.kernel.org/intel-wired-lan/ia3pr11mb89860a16782937c7e8c2e2dee5...@ia3pr11mb8986.namprd11.prod.outlook.com/ > > Should this be corrected to igb_set_rxfh() to match the actual code?
Thank you for pointing out. I'll fix it and send it as v6.
