On 2026-02-08 11:25:40 [-0500], Willem de Bruijn wrote: > > >> But it's more like a question to maintainers whether it is acceptable > > >> way of "fixing" drivers or it's no-go solution > > > > > > Requiring OPT_TSONLY unless CAP_NET_RAW would break legacy users. > > > > Well, they are kinda broken already. Without OPT_TSONLY and CAP_NET_RAW all > > TX > > timestamps are silently dropped. > > Are you referring to sysctl_tstamp_allow_data? > > That is enabled by default.
Yes. If so, then we don't need the check below which requires sk_callback_lock. Are SIOCSHWTSTAMP the legacy users or the ones which do not set OPT_TSONLY? I would suggest to move the CAP_NET_RAW check to the point where timestamping is getting enabled. Also if ndo_hwtstamp_set is the preferred method of getting things done, I could check how many old ones are can be easily converted… > > To receive these timestamps users have to get > > CAP_NET_RAW permission, and it will work with the updated logic as well... Sebastian
