>From: Intel-wired-lan <[email protected]> on behalf of Petr >Oros <[email protected]> >Sent: Wednesday, February 18, 2026 10:14 PM >To: [email protected] <[email protected]> >Cc: Vecera, Ivan <[email protected]>; Kitszel, Przemyslaw ><[email protected]>; Eric Dumazet <[email protected]>; >Kubalewski, Arkadiusz <[email protected]>; Andrew Lunn ><[email protected]>; Nguyen, Anthony L <[email protected]>; Simon >Horman <[email protected]>; [email protected] ><[email protected]>; Jakub Kicinski <[email protected]>; Paolo >Abeni <[email protected]>; David S. Miller <[email protected]>; >[email protected] <[email protected]> >Subject: [Intel-wired-lan] [PATCH iwl-net] ice: fix missing dpll notification >for SW pins > >ice_dpll_notify_changes() sends dpll_pin_change_ntf() only for the >direct CGU input pin stored in d->active_input. Software-controlled >pins (SMA/U.FL) are separate dpll_pin objects that wrap a backing CGU >input, but they never receive a change notification. As a result, >userspace consumers such as synce4l that monitor SMA pins via dpll >netlink never learn when the pin state transitions (e.g. from >SELECTABLE to CONNECTED), even though 'dpll pin show' reports the >correct state on demand. > > >When the active input changes, also send dpll_pin_change_ntf() for any >registered SMA/U.FL input pin whose backing CGU input matches the old >or new active input. > > >Fixes: 2dd5d03c77e2 ("ice: redesign dpll sma/u.fl pins control") >Signed-off-by: Petr Oros <[email protected]> >--- > drivers/net/ethernet/intel/ice/ice_dpll.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > >diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c >b/drivers/net/ethernet/intel/ice/ice_dpll.c >index c2ad39bfe177db..6f855fe4c78d62 100644 >--- a/drivers/net/ethernet/intel/ice/ice_dpll.c >+++ b/drivers/net/ethernet/intel/ice/ice_dpll.c >@@ -2470,13 +2470,17 @@ static u64 ice_generate_clock_id(struct ice_pf *pf) > */ > static void ice_dpll_notify_changes(struct ice_dpll *d) > { >+ struct ice_dplls *dplls = &d->pf->dplls; > bool pin_notified = false; >+ int i;
Please declare within a loop itself Piotr
