This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- bitmap: introduce bitmap_weighted_xor() The function helps to XOR bitmaps and calculate Hamming weight of the result in one pass. > diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h > index b0395e4ccf90..5485076bb2d0 100644 > --- a/include/linux/bitmap.h > +++ b/include/linux/bitmap.h [ ... ] > @@ -352,6 +354,18 @@ unsigned int bitmap_weighted_or(unsigned long *dst, > const unsigned long *src1, > } > } > > +static __always_inline > +unsigned int bitmap_weighted_xor(unsigned long *dst, const unsigned long > *src1, > + const unsigned long *src2, unsigned int nbits) > +{ > + if (small_const_nbits(nbits)) { > + *dst = *src1 ^ *src2; > + return hweight_long(*dst & BITMAP_LAST_WORD_MASK(nbits)); > + } else { > + return __bitmap_weighted_xor(dst, src1, src2, nbits); > + } > +} Should bitmap_weighted_xor() be added to the API documentation block near the beginning of this header file? The documentation lists bitmap_weighted_or() at line 48 and bitmap_xor() at line 49. For consistency with the existing pattern, bitmap_weighted_xor() could be documented similarly to: "bitmap_weighted_xor(dst, src1, src2, nbits) *dst = *src1 ^ *src2. Returns Hamming Weight of dst". [ ... ]
