> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Yury Norov via Intel-wired-lan
> Sent: Monday, March 2, 2026 2:12 AM
> To: Nguyen, Anthony L <[email protected]>; David S. Miller
> <[email protected]>; Thomas Hellström
> <[email protected]>; Andrew Lunn
> <[email protected]>; Andrew Morton <[email protected]>;
> David Airlie <[email protected]>; Eric Dumazet <[email protected]>;
> Jakub Kicinski <[email protected]>; Brost, Matthew
> <[email protected]>; Paolo Abeni <[email protected]>; Kitszel,
> Przemyslaw <[email protected]>; Vivi, Rodrigo
> <[email protected]>; Simona Vetter <[email protected]>; Yury Norov
> <[email protected]>; Rasmus Villemoes <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected]; intel-wired-
> [email protected]
> Cc: Yury Norov <[email protected]>; Simon Horman <[email protected]>;
> David Laight <[email protected]>
> Subject: [Intel-wired-lan] [PATCH v2 3/4] ice: use bitmap_empty() in
> ice_vf_has_no_qs_ena
>
> bitmap_empty() is more verbose and efficient, as it stops traversing
> {r,t}xq_ena as soon as the 1st set bit found.
>
> Signed-off-by: Yury Norov <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> index c8bc952f05cd..772f6b07340d 100644
> --- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> @@ -1210,8 +1210,8 @@ bool ice_is_vf_trusted(struct ice_vf *vf)
> */
> bool ice_vf_has_no_qs_ena(struct ice_vf *vf) {
> - return (!bitmap_weight(vf->rxq_ena, ICE_MAX_RSS_QS_PER_VF) &&
> - !bitmap_weight(vf->txq_ena, ICE_MAX_RSS_QS_PER_VF));
> + return bitmap_empty(vf->rxq_ena, ICE_MAX_RSS_QS_PER_VF) &&
> + bitmap_empty(vf->txq_ena, ICE_MAX_RSS_QS_PER_VF);
> }
>
> /**
> --
> 2.43.0
Reviewed-by: Aleksandr Loktionov <[email protected]>
