> -----Original Message----- > From: Dawid Osuchowski <[email protected]> > Sent: Wednesday, March 11, 2026 9:07 AM > To: Korba, Przemyslaw <[email protected]>; > [email protected] > Cc: [email protected]; Nguyen, Anthony L <[email protected]>; > Kitszel, Przemyslaw <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix posted write support > for sideband queue operations > > On 2026-03-10 12:06 PM, Przemyslaw Korba wrote: > > On E830, PTP time adjustment commands sent via > > SBQ don't generate completion responses, causing the driver to > > timeout waiting and return -EIO, when trying: > > > > phc_ctl eth8 get adj 2 get > > dmesg: ice 0000:1a:00.0: PTP failed to adjust time, err -5 > > > > Add support for posted mode not to wait for completion response. > > > > Fixes: 8f5ee3c477a8 ("ice: add support for sideband messages") > > Signed-off-by: Przemyslaw Korba <[email protected]> > > Hey Przemek, > > Similarly to what I posted in response to your patch "[PATCH iwl-next] > i40e: PTP: set supported flags in ptp_clock_info", you are missing > Reviewed-by tags from internal review. I see you did send for internal > review but nobody actually provided an RB tag (at least not directly on > the internal list). > > -Dawid
Hi, thank you for the review! Yes, I've been a bit too quick - got internal review, but did not receive reviewed-by tag. Will keep that in mind next time.
