On 03/20 09:07, Bart Van Assche via Intel-wired-lan wrote: > Move the mutex_lock() call up to prevent that DCB settings change after > the first ice_query_port_ets() call. The second ice_query_port_ets() > call in ice_dcb_rebuild() is already protected by pf->tc_mutex. > > This also fixes a bug in an error path, as before taking the first > "goto dcb_error" in the function jumped over mutex_lock() to > mutex_unlock(). > > This bug has been detected by the clang thread-safety analyzer.
nit: I believe the subject should be [PATCH iwl-net] ice: fix locking in ice_dcb_rebuild() since iwl-net is the target tree name.
