The current code incorrectly uses VIRTCHNL2_CAP_PTP_SET_DEVICE_CLK_TIME
for both direct and mailbox capabilities, causing mailbox-only support
to be ignored and potentially reporting IDPF_PTP_NONE.

Fixes: d5dba8f7206da ("idpf: add PTP clock configuration")
Signed-off-by: Alok Tiwari <[email protected]>
---
I did not hit a runtime failure directly, but this logic is inconsistent
with the capability definitions.
---
 drivers/net/ethernet/intel/idpf/idpf_ptp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/idpf/idpf_ptp.c 
b/drivers/net/ethernet/intel/idpf/idpf_ptp.c
index eec91c4f0a75..3295e2f1db9c 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_ptp.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_ptp.c
@@ -51,7 +51,7 @@ void idpf_ptp_get_features_access(const struct idpf_adapter 
*adapter)
 
        /* Set the device clock time */
        direct = VIRTCHNL2_CAP_PTP_SET_DEVICE_CLK_TIME;
-       mailbox = VIRTCHNL2_CAP_PTP_SET_DEVICE_CLK_TIME;
+       mailbox = VIRTCHNL2_CAP_PTP_SET_DEVICE_CLK_TIME_MB;
        ptp->set_dev_clk_time_access = idpf_ptp_get_access(adapter,
                                                           direct,
                                                           mailbox);
-- 
2.50.1

Reply via email to